Repository navigation
Add async Always Encrypted crypto utilities (2/5) - #5079
cheenamalhotra wants to merge 4 commits into
Conversation
Split layer 2 from #4585: decrypt CEKs and verify CMK signatures asynchronously, preserving provider fallback and cancellation behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The signature-cache miss/publication path lacks tests proving canceled verification results stay out of the shared cache and uncanceled results are published and reused.
1 open issue
What changed in this PR
Adds the second foundation layer for async Always Encrypted support, building on the async key cache in #5077. Command integration remains deferred to later layers; no public APIs change.
Changes:
- Adds async column-encryption key decryption with provider selection and candidate fallback.
- Adds async column-master-key signature verification with cancellation handling and shared-cache publication.
- Adds unit tests for provider dispatch, fallback, error wrapping, cancellation, and cached signature results.
| File | Description |
|---|---|
src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/SqlSecurityUtilityTests.cs |
Adds regression coverage for async cryptographic utilities. |
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlSecurityUtility.cs |
Adds async key-decryption and signature-verification helpers. |
Review effort: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/cheena/async-ae-key-cache #5079 +/- ##
=================================================================
+ Coverage 70.07% 70.27% +0.19%
=================================================================
Files 314 314
Lines 69893 70018 +125
=================================================================
+ Hits 48981 49202 +221
+ Misses 20912 20816 -96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add isolated global-provider coverage for canceled inline and suspended verification results, retry, and positive/negative result reuse. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Description
Layer 2/5 split from #4585; depends on #5077. Adds async CEK decryption and CMK signature verification in
SqlSecurityUtility, preserving provider selection, candidate fallback, error wrapping, cancellation precedence, and signature-cache publication. The production delta matches source head5f1b860410426f8c1af3eb55bfac0e7354bd2ac7; newer-main changes remain intact. No call-site wiring or public API changes in this layer.Includes layer 1's comment-only update at
db16a2add7bca13a8e0d31b97aa6bca0a35a5e7c. Retains milestone8.1.0-preview1.Issues
Relates to #3672. Split from #4585, which remains untouched. Depends on #5077.
Testing
Relocated the source utility cases to
UnitTests/Microsoft/Data/SqlClient/SqlSecurityUtilityTests.cs: 23 methods / 28 cases. Split combined and completion-mode scenarios; added required sections/XML summaries and strengthened final-error assertions. Retained the verification-capable nested provider and metadata helpers. Cache-only tests/providers remain in layer 1.Passed: 44 tests, zero skipped, in each net10.0 configuration (28 utility + 16 cache cases). Filter discovery was verified; before importing production changes the new tests failed compilation because the async methods were absent.
Passed: net462 builds in Debug and Release, zero warnings/errors.
No SQL Server, AKV, or net462 runtime tests were run on macOS. Command/enclave integration belongs to later layers. Existing unrelated xUnit discovery warnings were not changed.
Guidelines
Please review the contribution guidelines before submitting a pull request: